London | May-2025 | Hendrine Zeraua | STD Sprint-2 #653
+307
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g., '399p' → '£3.99'
…r, file name, and extension
…calculation is not a function
cjyuan
added
Review in progress
cjyuan
reviewed
Jul 17, 2025
Comment on lines
+24
to
+26
| function capitalise(str) { | ||
| str = `${str[0].toUpperCase()}${str.slice(1)}`; | ||
| return str; |
There was a problem hiding this comment.
The function block is not properly closed.
There was a problem hiding this comment.
Hi CJ,
I've added the missing curly braces for the function capitalise but for some reason I cannot spot the modified files in Sprint-1. Could you please direct me? I did check Sprint-1 - key-exercises - 3- paths.js and 3-mandatory-interpret - 1-percentage-change.js without success.
I appreciate your help reviewing this.
cjyuan
added
Reviewed
|
I shared a screenshot of the two modified files in my previous comment. You can also see what files are modified by clicking the "Files changed" tab: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Briefly explain your PR.
Answered all exercise questions
Fixed errors & Explained
Completed stretch questions with thoughtful answers
Questions
No questions at this time.